fix: add missing exports #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Sep 3, 2025
This was fixed upstream in nodejs/uvwasi#308. Also, let's apply nodejs/uvwasi#311 to ensure that all the symbols that Node needs are exported.
6 tasks
guybedford
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/aduh95/node/actions/runs/17417307474/job/49448566498 shows that some symbol are still missing. I guess I failed to realize earlier because they were cached on my machine. I've confirmed with https://github.com/aduh95/node/actions/runs/17433927156/job/49498659482 that this commit does export the correct symbols (to build Node.js anyway).
This also remove an inconsistency where we would add the visibility flag for all compilers except on WIN32 and CYGWIN, but it makes more sense to set it only for the three compilers for which we change the default visibility to
hidden.