fix(fs-access-mode-constants): don't modify other thing#382
fix(fs-access-mode-constants): don't modify other thing#382AugustinMauroy wants to merge 6 commits intomainfrom
fs-access-mode-constants): don't modify other thing#382Conversation
AugustinMauroy
added
the
awaiting reviewer
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Thanks for this!
How-so does the migration unintentionally affect other files?
There was a problem hiding this comment.
The utilities here could use some unit tests 🙂
There was a problem hiding this comment.
what do you mean ?
There was a problem hiding this comment.
Sorry, I don't understand what is unclear 😅
There was a problem hiding this comment.
you mean that you wan unit test on function written inside the codemod ?
that need to be done as this:
- move them to utility package
- add tests
There was a problem hiding this comment.
Why is it necessary to extract them into a package? Just co-locate a .test.ts file here and cover the utils, no?
There was a problem hiding this comment.
oh yeah we can do that I'm also going to see if we can reduce amount of code there
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
New changes look good 🙂
2 participants
Description
Alex (codemod) reported that this codemod make changes on other file.
So: