feat(DEP0064): handle `tls.createSecurePair` deprecation by technologic-technologic · Pull Request #266 · nodejs/userland-migrations

technologic-technologic · 2025-11-06T04:57:46Z

This pull request implements the codemod to replace deprecated `tls.createSecurePair()` with `TLSSocket`, addressing DEP0064.

This PR closes feat: handle tls.createSecurePair() depreciation #127

Changes included:

Updated the codemod workflow to transform createSecurePair(...) into new TLSSocket(underlyingSocket, {...}), preserving tls.TLSSocket for namespace usage.
Rewrote imports to replace { createSecurePair } with { TLSSocket } in CJS/ESM (keeps namespace imports intact).
Renamed assigned variables pair → socket where applicable.
Added tests for cjs/esm (destructured, namespace, flags, and mixed symbols).
Ensured idempotent runs and minimal, repo-style edits.
Added README.md and package.json metadata.
Added tests for assigned variables, destructured imports.

This PR is part of the feature branch feat/tls-createSecurePair-to-TLSSocket.

…nt '`tls-create-secure-pair-to-tls-socket`. '

recipes/tls-create-secure-pair-to-tls-socket/README.md

AugustinMauroy · 2025-11-06T08:15:48Z

npm i on root should update the lock file and fix the ci

Missing import test case

défaut import ESM
ESM dynamic import

recipes/tls-create-secure-pair-to-tls-socket/src/workflow.ts

…d ESM default and dynamic import cases

…uded default and dynamic ESM imports + needed refactors as PR comments) WHAT Changed: - AST-based migration - ESM/default/dynamic cases - Normalize rewritten CJS requires to `node:tls` as suggested to code section - Remove duplicated `getNodeImportStatements/getNodeRequireCalls` invocations that attempted to handle `'node:tls'` vs `'tls'`

…d dynamic import (await/then) WHAT : - ESM default import - ESM dynamic import (await assignment) - ESM dynamic import (then callback)

…cation`)' into feat(`tls-createSecurePair-deprecation`)

recipes/tls-create-secure-pair-to-tls-socket/src/workflow.ts

JakobJingleheimer · 2025-11-15T15:52:11Z

Thanks for this!

AugustinMauroy · 2025-12-13T09:40:37Z

bump @technologic-technologic 👋

AugustinMauroy · 2026-02-02T13:41:27Z

@JakobJingleheimer i had take hand here, it's much more lighter

JakobJingleheimer

Thanks for this! The code is really readable / easy to follow 🙂

Sorry this took a while for me to get back to this. I was bereaved right after my last review and then lost track.

@brunocroh I think a lot of this is already handled by your fancy utils. Could you take a look?

recipes/tls-create-secure-pair-to-tls-socket/src/workflow.ts

brunocroh · 2026-03-21T23:29:30Z

@AugustinMauroy do you know what the problem with the CI is here?

AugustinMauroy · 2026-03-22T10:18:54Z

@AugustinMauroy do you know what the problem with the CI is here?

I'm going to check but I think something like that should fix it:

git fetch origin main && git restore --source=origin/main -- package-lock.json && npm I

this issue is dude to the fact that ast-grep (used for test on utility package) need to resolve by arch since it's node native add-on

AugustinMauroy

LGMT !

JakobJingleheimer

W00t! Go team 🙌

technologic-technologic and others added 3 commits November 5, 2025 22:30

feat(createSecurePair-deprecation): handle Node.js DEP0064 migration

5f2d37f

fix: updated 'tls-createsecurepair-to-socket' to a kebab-case complia…

60e516e

…nt '`tls-create-secure-pair-to-tls-socket`. '

Merge branch 'main' into feat(tls-createSecurePair-deprecation)

505e9f1

AugustinMauroy reviewed Nov 6, 2025

View reviewed changes

recipes/tls-create-secure-pair-to-tls-socket/README.md Outdated Show resolved Hide resolved

AugustinMauroy reviewed Nov 6, 2025

View reviewed changes

recipes/tls-create-secure-pair-to-tls-socket/src/workflow.ts Outdated Show resolved Hide resolved

AugustinMauroy reviewed Nov 6, 2025

View reviewed changes

recipes/tls-create-secure-pair-to-tls-socket/src/workflow.ts Outdated Show resolved Hide resolved

AugustinMauroy reviewed Nov 6, 2025

View reviewed changes

recipes/tls-create-secure-pair-to-tls-socket/src/workflow.ts Outdated Show resolved Hide resolved

technologic-technologic added 5 commits November 9, 2025 23:11

docs(tls-createSecurePair-deprecation): switch to diff examples; ad…

697778b

…d ESM default and dynamic import cases

chore(deps): update lockfile

cecef62

test(tls-createSecurePair-deprecation): cover ESM default import an…

5aca91e

…d dynamic import (await/then) WHAT : - ESM default import - ESM dynamic import (await assignment) - ESM dynamic import (then callback)

Merge remote-tracking branch 'origin/feat(`tls-createSecurePair-depre…

ad2fa9f

…cation`)' into feat(`tls-createSecurePair-deprecation`)

JakobJingleheimer reviewed Nov 15, 2025

View reviewed changes

AugustinMauroy added the awaiting author Reviewer has requested something from the author label Dec 13, 2025

AugustinMauroy added 3 commits February 2, 2026 12:08

Merge branch 'main' into pr/266

7993e8b

WIP

bc480f6

Update workflow.ts

da7d3c8

AugustinMauroy force-pushed the feat(`tls-createSecurePair-deprecation`) branch from 62a736a to da7d3c8 Compare February 2, 2026 13:38

Update package-lock.json

c7b610f

AugustinMauroy force-pushed the feat(`tls-createSecurePair-deprecation`) branch from 2268a5e to c7b610f Compare February 2, 2026 13:47

AugustinMauroy added 3 commits February 2, 2026 15:00

simplify

02bc9ae

Update workflow.ts

26c1af5

use is

da6a021

JakobJingleheimer changed the title ~~feat(tls-create-secure-pair-deprecation): handle Node.js DEP0064 migration~~ feat(DEP0064): handle tls.createSecurePair deprecation Mar 8, 2026

JakobJingleheimer reviewed Mar 21, 2026

View reviewed changes

update updateBinding function, and replace usage in recipe

8704cac

brunocroh added 4 commits March 21, 2026 23:09

update resolveBindingPath to handle dynamic imports

76086c8

chore: remove unique fn

1fa9b4d

chore: lint

967ec5d

chore: dependency

ad187e7

brunocroh self-requested a review March 21, 2026 23:18

brunocroh approved these changes Mar 21, 2026

View reviewed changes

Update package-lock.json

96de7c6

AugustinMauroy approved these changes Mar 22, 2026

View reviewed changes

brunocroh requested a review from JakobJingleheimer March 22, 2026 13:38

JakobJingleheimer approved these changes Mar 22, 2026

View reviewed changes

brunocroh merged commit 6d6485b into nodejs:main Mar 22, 2026
18 checks passed

Uh oh!

Conversation

technologic-technologic commented Nov 6, 2025

This pull request implements the codemod to replace deprecated tls.createSecurePair() with TLSSocket, addressing DEP0064.

Changes included:

Uh oh!

Uh oh!

AugustinMauroy commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer commented Nov 15, 2025

Uh oh!

AugustinMauroy commented Dec 13, 2025

Uh oh!

AugustinMauroy commented Feb 2, 2026

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brunocroh commented Mar 21, 2026

Uh oh!

AugustinMauroy commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

This pull request implements the codemod to replace deprecated `tls.createSecurePair()` with `TLSSocket`, addressing DEP0064.

AugustinMauroy commented Nov 6, 2025 •

edited

Loading

AugustinMauroy commented Mar 22, 2026 •

edited

Loading