Skip to content

test: deflake issue-5137 stream count assertion #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 2 commits into from
May 10, 2026
Merged

test: deflake issue-5137 stream count assertion #5243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c15c29a
test: deflake issue-5137 stream count assertion
trivikr May 6, 2026
e6f9672
test: remove timeout fallback from issue 5137 retry test
trivikr May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/issue-5137.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,16 @@ test('RetryAgent rejects after exhausting retries on HTTP/2 stream timeout', asy
const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))

let streamCount = 0
let resolveStreamCount
const streamCountReached = new Promise(resolve => {
resolveStreamCount = resolve
})

server.on('stream', (stream) => {
streamCount++
if (streamCount === 3) {
resolveStreamCount()
}
// Never respond — simulates a perpetual stream timeout
})

Expand Down Expand Up @@ -57,6 +65,8 @@ test('RetryAgent rejects after exhausting retries on HTTP/2 stream timeout', asy
message: /stream timeout/
})

await streamCountReached

Comment thread
trivikr marked this conversation as resolved.
// Verify that all 3 retries actually reached the server
t.equal(streamCount, 3, 'server should have received all 3 request attempts')

Expand Down
Loading