fix(test): increase connect-timeout guard timeout and use Promise.race#5230
Open
fix(test): increase connect-timeout guard timeout and use Promise.race#5230
Conversation
The guard timeout of 2000ms was too tight for the 1000ms connect timeout on slower CI runners (e.g. Windows), causing the test to flakily fail with t.fail() before the expected callback fired. Changes: - Increased guard timeout from 2000ms to 5000ms for headroom - Replaced bare t.fail() with t.fail() + descriptive message - Wrapped the request callback in Promise.race with t.completed so the test resolves cleanly when assertions succeed rather than relying solely on t.completed which can hang after fail()
Member
|
Looks like one of the commits from this PR was pushed to main by mistake in e58fff7 Should we enable branch protection on main to require pull requests, to avoid pushes by mistake? |
metcoder95
reviewed
May 7, 2026
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
lgtm, just merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5187.
The guard timeout of 2000ms was too tight for the 1000ms connect timeout on
slower CI runners (e.g. Windows), causing the test to flakily fail with
t.fail()before the expected callback fired.Changes:
t.fail()witht.fail('...')+ descriptive messagePromise.racewitht.completedso thetest resolves cleanly when assertions succeed rather than relying solely on
t.completedwhich can hang afterfail()