fix(h2): remove incorrect stream state check in end handler #4762
+8
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'end' event handler in client-h2.js was incorrectly treating stream state 6 (HALF_CLOSED_REMOTE) as an error condition. This state is the expected state when the peer sends END_STREAM, per the HTTP/2 spec. The timing of when the stream reaches this state varies across platforms, causing the Dispatcher#Connect test in test/http2-dispatcher.js to fail intermittently on macOS with "HTTP/2: stream half-closed (remote)" error. This commit simplifies the 'end' event handler by: - Removing the unnecessary stream state check - Removing the duplicate kOpenStreams decrement (already handled in 'close') - Always completing the request normally when 'end' fires The stream cleanup is properly handled by the 'close' event handler, which decrements kOpenStreams and manages session references. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dispatcher#Connecttest on macOS intest/http2-dispatcher.jsProblem
The test was failing intermittently on macOS with:
The root cause was a stream state check
stream.state.state < 6that excluded state 6, but this is the normal state when the remote side finishes sending data. Timing differences across platforms caused this to appear as a flaky test.Fix
Simplified the 'end' event handler by:
kOpenStreamsdecrement (the 'close' handler already handles this)Test plan
test/http2-dispatcher.jspasses (includingDispatcher#Connect)