fix: remove empty padding in mobile navbar when navItems is empty#8723
Open
veeresh8055 wants to merge 1 commit intonodejs:mainfrom
Open
fix: remove empty padding in mobile navbar when navItems is empty#8723veeresh8055 wants to merge 1 commit intonodejs:mainfrom
veeresh8055 wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the mobile navigation shows empty padding when the NavBar does not contain any children.
Solution
Added a conditional check before rendering the navbar so it only renders when navigation items exist.
navItems && navItems.length > 0
This prevents the navbar container from rendering when there are no items, removing the extra empty padding in the mobile navigation.
Fixes #8719