build: adds configure flag notargettype#7437
Closed
eljefedelrodeodeljefe wants to merge 1 commit intonodejs:masterfrom
eljefedelrodeodeljefe:build/notargettype
Closed
build: adds configure flag notargettype#7437eljefedelrodeodeljefe wants to merge 1 commit intonodejs:masterfrom eljefedelrodeodeljefe:build/notargettype
eljefedelrodeodeljefe wants to merge 1 commit intonodejs:masterfrom
eljefedelrodeodeljefe:build/notargettype
Conversation
This flag is useful, to make gyp not build and link node cores /src/*.cc files. However all dependecnies will be built. This can be used to build node proper with an arbitrary build runner and/ or with itself.
Member
|
@nodejs/build |
Contributor
Author
|
Ref: This is needed for #7440 but can also used in other contexts. |
Member
|
I'm not seeing anything in here that warrants doing this as a separate PR, particularly in vcbuild.bat where the new variable isn't even used. I'd suggest closing this and rolling it up in proposed changes in #7440 unless you can demonstrate usefulness outside of that work. |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
Member
|
Closing due to lack of forward progress on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
buildDescription of change
In the wake of #7440 in order to replace GYP nodejs/CTC#2, this would be the first step. Effectively
./configure --no-target-typewill still compile any dependency and runjs2c, but not let gypgcc src/*.cc -c -o out/*.oand run the linker as last build step.This can be used, as presented in the above PR, to build node-core with node itself.
In order to fully compile without gyp, it's a long way, but definitely doable