src: skip duplicate UTF-8 validation in TextDecoder fatal path#63231
Open
mertcanaltin wants to merge 2 commits into
Open
src: skip duplicate UTF-8 validation in TextDecoder fatal path#63231mertcanaltin wants to merge 2 commits into
mertcanaltin wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
1ea0c09 to
25fe9af
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63231 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.01%
==========================================
Files 713 713
Lines 224950 224976 +26
Branches 42530 42542 +12
==========================================
+ Hits 202548 202554 +6
- Misses 14188 14191 +3
- Partials 8214 8231 +17
🚀 New features to boost your workflow:
|
anonrig
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TextDecoder's strict mode, the utf-8 buffer was being validated twice, I removed the second validation, non-asci decoding in strict mode is now 27–34% faster
Bench results (verry long, I wrote a gist file):
https://gist.github.com/mertcanaltin/42f2fe0808e85741bcc76e7f59a4229e
Short results: