Skip to content

test: reduce flakiness of different-registry-per-thread#63209

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:unflaky-test-process-finalization
May 11, 2026
Merged

test: reduce flakiness of different-registry-per-thread#63209
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:unflaky-test-process-finalization

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 9, 2026

There was an assumption that the WeakRef would be kept alive but it seems to not always be true on Windows. This commit makes sure it's kept alive.

Refs: #63057 (comment)
Fixes: #63056

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 9, 2026
@aduh95
test: reduce flakiness of different-registry-per-thread
fc9c902 
There was an assumption that the `WeakRef` would be kept alive but
it seems to not always be true on Windows. This commit makes sure
it's kept alive.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the unflaky-test-process-finalization branch from ed9990d to fc9c902 Compare May 9, 2026 12:52
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@inoway46 inoway46 mentioned this pull request May 9, 2026
Open
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (bbf51ad) to head (1a9791e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63209      +/-   ##
==========================================
- Coverage   90.03%   90.03%   -0.01%     
==========================================
  Files         713      713              
  Lines      224950   224950              
  Branches    42532    42534       +2     
==========================================
- Hits       202542   202539       -3     
- Misses      14175    14185      +10     
+ Partials     8233     8226       -7

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented May 9, 2026 •
edited
Loading

Pulled in b83d76c from #63214 4d4a78c from #63220 to get a green CI

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@inoway46 @aduh95
test: relax test-memory-usage arrayBuffers check
1a9791e 
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@aduh95 aduh95 force-pushed the unflaky-test-process-finalization branch from 96323a2 to 1a9791e Compare May 10, 2026 08:10
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 10, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73315/

MoLow
MoLow approved these changes May 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mertcanaltin
mertcanaltin approved these changes May 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added the fast-track PRs that do not need to wait for 72 hours to land. label May 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 10, 2026

Fast-track has been requested by @panva. Please 👍 to approve.

@ShogunPanda ShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 11, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2026
@nodejs-github-bot nodejs-github-bot merged commit 130398a into nodejs:main May 11, 2026
85 of 86 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 11, 2026

Landed in 130398a

@inoway46 inoway46 mentioned this pull request May 11, 2026
Closed
@thisalihassan thisalihassan mentioned this pull request May 11, 2026
Open
@aduh95 aduh95 deleted the unflaky-test-process-finalization branch May 11, 2026 12:08
@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented May 11, 2026

This should have landed with commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. , sorry @inoway46 you should have gotten the credit

@aduh95 aduh95 mentioned this pull request May 11, 2026
Open
@inoway46
Copy link
Copy Markdown
Contributor

inoway46 commented May 11, 2026

Thank you for taking care of this, I really appreciate it!

@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@panva panva panva approved these changes

@MoLow MoLow MoLow approved these changes

@H4ad H4ad H4ad approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

+1 more reviewer

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel.test-process-finalization is flaky

10 participants

@aduh95 @nodejs-github-bot @inoway46 @ljharb @ShogunPanda @panva @MoLow @H4ad @RafaelGSS @mertcanaltin