tools: use different branch for tool updates on staging branches#63110
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
tool-update-no-conflict
branch
from
c959895 to
811d178
Compare
jasnell
approved these changes
May 4, 2026
aduh95
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63110 ✔ Done loading data for nodejs/node/pull/63110 ----------------------------------- PR info ------------------------------------ Title tools: use different branch for tool updates on staging branches (#63110) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:tool-update-no-conflict -> nodejs:main Labels meta, author ready, lts-watch-v22.x Commits 1 - tools: use different branch for tool updates on staging branches Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63110 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63110 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 04 May 2026 08:26:25 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63110#pullrequestreview-4221272415 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 63110 remote: Internal Server Error fatal: unable to access 'https://github.com/nodejs/node/': The requested URL returned error: 500https://github.com/nodejs/node/actions/runs/25675882689 |
richardlau
approved these changes
May 11, 2026
marco-ippolito
approved these changes
May 11, 2026
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a349018 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow having concurrent update PRs for the same tool on different branches (e.g. Undici@6 version bump for
v22.x-stagingin #63109 was overwriting the Undici@8 formainin #63092).The solution I went with is to add the base branch name in the PR branch name for non-
mainupdates.