lib,permission: add permission.drop#62672
Conversation
|
Review requested:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #62672 +/- ##
==========================================
- Coverage 91.52% 89.67% -1.86%
==========================================
Files 360 712 +352
Lines 151793 221411 +69618
Branches 23970 42415 +18445
==========================================
+ Hits 138933 198546 +59613
- Misses 12586 14688 +2102
- Partials 274 8177 +7903
🚀 New features to boost your workflow:
|
|
As mentioned in my comments on the linked issue, I feel like it should be explicitly documented that this only drops permissions and does not close currently open file handles, sockets etc, that it is expected behaviour and is the app code's responsibility to close/release those if they are no longer required. |
f36bd66 to
995de8e
Compare
db19643 to
4de2d41
Compare
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
4de2d41 to
ff892e8
Compare
Refs: #62223