Skip to content

crypto: default ML-KEM and ML-DSA pkcs8 export to seed-only format #62178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panva wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −2
Open

crypto: default ML-KEM and ML-DSA pkcs8 export to seed-only format #62178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2121,6 +2121,11 @@ type, value, and parameters. This method is not
<!-- YAML
added: v11.6.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/62178
description: ML-KEM and ML-DSA private key `'pkcs8'` export now
uses seed-only format by default when a seed is
available.
- version: v15.9.0
pr-url: https://github.com/nodejs/node/pull/37081
description: Added support for `'jwk'` format.
Expand Down
17 changes: 17 additions & 0 deletions src/crypto/crypto_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,23 @@ void InitCryptoOnce() {
#endif

OPENSSL_init_ssl(0, settings);

#if OPENSSL_WITH_PQC
// Configure all loaded providers to prefer seed-only format for ML-KEM and
// ML-DSA private keys in PKCS#8 export, falling back to priv-only when a
// seed is not available. The provider encoder reads these parameters at
// encoding time via ossl_prov_ctx_get_param().
OSSL_PROVIDER_do_all(
nullptr,
[](OSSL_PROVIDER* provider, void*) -> int {
OSSL_PROVIDER_add_conf_parameter(
provider, "ml-kem.output_formats", "seed-only,priv-only");
OSSL_PROVIDER_add_conf_parameter(
provider, "ml-dsa.output_formats", "seed-only,priv-only");
return 1;
},
nullptr);
#endif
OPENSSL_INIT_free(settings);
settings = nullptr;

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-pqc-key-objects-ml-dsa.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ for (const [asymmetricKeyType, pubLen] of [
assertPublicKey(createPublicKey(key));
key.export({ format: 'der', type: 'pkcs8' });
if (hasSeed) {
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private);
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private_seed_only);
} else {
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private_priv_only);
}
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-pqc-key-objects-ml-kem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ for (const asymmetricKeyType of ['ml-kem-512', 'ml-kem-768', 'ml-kem-1024']) {
assertPublicKey(createPublicKey(key));
key.export({ format: 'der', type: 'pkcs8' });
if (hasSeed) {
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private);
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private_seed_only);
} else {
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private_priv_only);
}
Expand Down
Loading