Skip to content

typings: rationalise TypedArray types #62174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Renegade334 wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −43
Open

typings: rationalise TypedArray types #62174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions typings/globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,20 @@ declare global {
| BigUint64Array
| BigInt64Array;

type TypedArrayConstructor =
| typeof Uint8Array
| typeof Uint8ClampedArray
| typeof Uint16Array
| typeof Uint32Array
| typeof Int8Array
| typeof Int16Array
| typeof Int32Array
| typeof Float16Array
| typeof Float32Array
| typeof Float64Array
| typeof BigUint64Array
| typeof BigInt64Array;

namespace NodeJS {
interface Global {
internalBinding<T extends InternalBindingKeys>(binding: T): InternalBindingMap[T]
Expand Down
61 changes: 18 additions & 43 deletions typings/primordials.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type UncurryGetter<O, K extends keyof O, T = O> =
type UncurrySetter<O, K extends keyof O, T = O> =
O[K] extends infer V ? (self: T, value: V) => void : never;

type TypedArrayContentType<T extends TypedArray> = T extends { [k: number]: infer V } ? V : never;
type TypedArrayContentType<T extends TypedArrayConstructor> = InstanceType<T>[number];

/**
* Primordials are a way to safely use globals without fear of global mutation
Expand Down Expand Up @@ -472,43 +472,30 @@ declare namespace primordials {
export const SyntaxErrorPrototype: typeof SyntaxError.prototype
export import TypeError = globalThis.TypeError;
export const TypeErrorPrototype: typeof TypeError.prototype
export function TypedArrayFrom<T extends TypedArray>(
constructor: new (length: number) => T,
source:
| Iterable<TypedArrayContentType<T>>
| ArrayLike<TypedArrayContentType<T>>,
): T;
export function TypedArrayFrom<T extends TypedArray, U, THIS_ARG = undefined>(
constructor: new (length: number) => T,
export function TypedArrayFrom<T extends TypedArrayConstructor>(
constructor: T,
source: Iterable<TypedArrayContentType<T>> | ArrayLike<TypedArrayContentType<T>>,
): InstanceType<T>
export function TypedArrayFrom<T extends TypedArrayConstructor, U, THIS_ARG = undefined>(
constructor: T,
source: Iterable<U> | ArrayLike<U>,
mapfn: (
this: THIS_ARG,
value: U,
index: number,
) => TypedArrayContentType<T>,
thisArg?: THIS_ARG,
): T;
export function TypedArrayOf<T extends TypedArray>(
constructor: new (length: number) => T,
...items: readonly TypedArrayContentType<T>[]
): T;
export function TypedArrayOfApply<T extends TypedArray>(
constructor: new (length: number) => T,
): InstanceType<T>;
export function TypedArrayOf<T extends TypedArrayConstructor>(
constructor: T,
...items: TypedArrayContentType<T>[],
): InstanceType<T>;
export function TypedArrayOfApply<T extends TypedArrayConstructor>(
constructor: T,
items: readonly TypedArrayContentType<T>[],
): T;
export const TypedArray: TypedArray;
export const TypedArrayPrototype:
| typeof Uint8Array.prototype
| typeof Int8Array.prototype
| typeof Uint16Array.prototype
| typeof Int16Array.prototype
| typeof Uint32Array.prototype
| typeof Int32Array.prototype
| typeof Float32Array.prototype
| typeof Float64Array.prototype
| typeof BigInt64Array.prototype
| typeof BigUint64Array.prototype
| typeof Uint8ClampedArray.prototype;
): InstanceType<T>;
export const TypedArray: TypedArrayConstructor;
export const TypedArrayPrototype: TypedArrayConstructor["prototype"];
export const TypedArrayPrototypeGetBuffer: UncurryGetter<TypedArray, "buffer">;
export const TypedArrayPrototypeGetByteLength: UncurryGetter<TypedArray, "byteLength">;
export const TypedArrayPrototypeGetByteOffset: UncurryGetter<TypedArray, "byteOffset">;
Expand All @@ -519,19 +506,7 @@ declare namespace primordials {
export function TypedArrayPrototypeSet<T extends TypedArray>(self: T, ...args: Parameters<T["set"]>): ReturnType<T["set"]>;
export function TypedArrayPrototypeSubarray<T extends TypedArray>(self: T, ...args: Parameters<T["subarray"]>): ReturnType<T["subarray"]>;
export function TypedArrayPrototypeSlice<T extends TypedArray>(self: T, ...args: Parameters<T["slice"]>): ReturnType<T["slice"]>;
export function TypedArrayPrototypeGetSymbolToStringTag(self: unknown):
| 'Int8Array'
| 'Int16Array'
| 'Int32Array'
| 'Uint8Array'
| 'Uint16Array'
| 'Uint32Array'
| 'Uint8ClampedArray'
| 'BigInt64Array'
| 'BigUint64Array'
| 'Float32Array'
| 'Float64Array'
| undefined;
export function TypedArrayPrototypeGetSymbolToStringTag(self: unknown): TypedArray[typeof Symbol.toStringTag] | undefined;
export import URIError = globalThis.URIError;
export const URIErrorPrototype: typeof URIError.prototype
export import Uint16Array = globalThis.Uint16Array;
Expand Down
Loading