-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
net: add setTypeOfService and getTypeOfService to Socket #61503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amyssnippet
wants to merge
33
commits into
nodejs:main
Choose a base branch
from
amyssnippet:fix/61489
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+428
−86
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
eb53d09
net: add setTOS and getTOS to Socket
amyssnippet 9e7a183
added doc
amyssnippet 14b3fb0
fixed some lint issues
amyssnippet f339cd0
already complete with validation and platform specific tests
amyssnippet d32f212
added: REPLACEME
amyssnippet 71ecbd7
common.mustCall used
amyssnippet c0407b2
undo: unrelated header was removed irrelevantly
amyssnippet 8439cfd
fix: resolve windows compilation and linter issues
amyssnippet fe329db
rollback to tcp only
amyssnippet 778580a
fix: ensure getTOS returns numeric default when handle lacks getTOS
amyssnippet efb5f88
fix: handle setTOS errors in afterConnect and use options.tos
amyssnippet 8dce839
fix: capture errno immediately after getsockopt failures
amyssnippet 1fb4683
fix: use correct length type for Windows getsockopt and fix DSCP mask…
amyssnippet 1084571
fix: validate options.tos in constructor
amyssnippet 0a90f1c
fix: use validateInt32 for options.tos and standardize GetTOS error
amyssnippet 603445d
fix: remove unused errno_val in TCPWrap::GetTOS POSIX path
amyssnippet f22a74c
test: add boundary value assertions for TOS
amyssnippet b272fda
test: add pre-connect TOS caching test
amyssnippet c6f1153
doc: add notes for setTOS and getTOS about pre-connect caching and OS…
amyssnippet fe14b34
fix: import UV_EBADF and remove duplicate mask declaration
amyssnippet 041c30a
fix: update TOS cache when handle lacks setTOS
amyssnippet 7516aff
doc: clarify pre-connect TOS test comment
amyssnippet 83d875c
refined: comments
amyssnippet c03162b
doc: remove prohibited 'Note that' phrases
amyssnippet b884430
fix: reorder includes for Windows compatibility and add missing POSIX…
amyssnippet c39d13e
fix: resolve windows header order and doc lint errors
amyssnippet 98747a7
feat: rename setTOS/getTOS to setTypeOfService/getTypeOfService for A…
amyssnippet 551a5d3
fix: update internal handle calls to use new TypeOfService method names
amyssnippet 2bb4591
win vs2022 ci fix
amyssnippet a2d4c36
added: todo for libuv api
amyssnippet b04b62f
fixed:win vs2022 lint ci
amyssnippet 569debb
feat: rename C++ methods from SetTOS/GetTOS to SetTypeOfService/GetTy…
amyssnippet e33561d
docs: update net.md for typeOfService option and fix lib/net.js const…
amyssnippet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.