Skip to content

Conversation

@Ayoub-Mabrouk
Copy link

Replace native array method (.push) with primordials (ArrayPrototypePush) in lib/internal/test_runner/utils.js for consistency and security. This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

Replace native array method (.push) with primordials (ArrayPrototypePush)
in lib/internal/test_runner/utils.js for consistency and security. This
improves protection against prototype pollution and aligns with the
primordials pattern used throughout the codebase.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (05d6b9b) to head (e2fec2d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/utils.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61204      +/-   ##
==========================================
- Coverage   88.53%   88.53%   -0.01%     
==========================================
  Files         703      703              
  Lines      208599   208599              
  Branches    40229    40225       -4     
==========================================
- Hits       184685   184676       -9     
- Misses      15939    15942       +3     
- Partials     7975     7981       +6     
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 61.27% <0.00%> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants