tools: simplify notify-on-push
#61050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have the repo setup to reject commits that do not contain any metadata, we can remove the custom logic that was trying to catch commits merged using the default commit message.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
cjihrig
approved these changes
Dec 13, 2025
aduh95
added
the
author ready
lpinca
approved these changes
Dec 17, 2025
avivkeller
approved these changes
Dec 18, 2025
avivkeller
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 25947d6 |
Member
|
The first workflow run following this commit has failed: https://github.com/nodejs/node/actions/runs/20343051888/job/58447549846 The docker retrieval timeout is presumably unrelated, but worth noting that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the repo setup to reject commits that do not contain any metadata, we can remove the custom logic that was trying to catch commits merged using the default commit message.
This will also make invalid message being reported as a failure, which IMO makes more sense that the current setting that always report a success.