test: skip tests not passing without NODE_OPTIONS support
#60912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60912 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 703 703
Lines 208406 208406
Branches 40215 40189 -26
==========================================
- Hits 184504 184473 -31
- Misses 15928 15949 +21
- Partials 7974 7984 +10 🚀 New features to boost your workflow:
|
aduh95
force-pushed
the
without-node-options
branch
from
41f070d to
c4176e8
Compare
Collaborator
Collaborator
Collaborator
Collaborator
benjamingr
approved these changes
Dec 6, 2025
aduh95
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/60912 ✔ Done loading data for nodejs/node/pull/60912 ----------------------------------- PR info ------------------------------------ Title test: skip tests not passing without `NODE_OPTIONS` support (#60912) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:without-node-options -> nodejs:main Labels meta, author ready, needs-ci Commits 1 - test: skip tests not passing without `NODE_OPTIONS` support Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60912 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60912 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 30 Nov 2025 19:55:11 GMT ✔ Approvals: 1 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/60912#pullrequestreview-3548028834 ✘ This PR needs to wait 9 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-12-04T16:01:17Z: https://ci.nodejs.org/job/node-test-pull-request/70388/ - Querying data for job/node-test-pull-request/70388/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/20002627874 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6e474c0 |
aduh95
added a commit
that referenced
this pull request
Dec 8, 2025
PR-URL: #60912 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out off of #60902