Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 30, 2025

Triggered by #60902, the first commit is from #61006 which should land first

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 30, 2025
@aduh95 aduh95 marked this pull request as draft November 30, 2025 16:04
@aduh95 aduh95 marked this pull request as ready for review November 30, 2025 16:14
@aduh95 aduh95 marked this pull request as draft November 30, 2025 16:15
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (e28656a) to head (672f50e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60906   +/-   ##
=======================================
  Coverage   88.51%   88.52%           
=======================================
  Files         703      703           
  Lines      208496   208496           
  Branches    40213    40212    -1     
=======================================
+ Hits       184555   184568   +13     
- Misses      15955    15958    +3     
+ Partials     7986     7970   -16     
Files with missing lines Coverage Δ
src/node_options.cc 77.80% <ø> (-0.11%) ⬇️
src/node_options.h 97.89% <100.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 force-pushed the fix-nosqlite-tests branch from 7d9e358 to 98213cb Compare November 30, 2025 18:12
@aduh95 aduh95 marked this pull request as ready for review November 30, 2025 18:12
@aduh95 aduh95 marked this pull request as draft November 30, 2025 21:31
@aduh95 aduh95 force-pushed the fix-nosqlite-tests branch from 98213cb to 96c122f Compare December 7, 2025 22:30
@aduh95 aduh95 marked this pull request as ready for review December 7, 2025 22:33
@aduh95 aduh95 marked this pull request as draft December 8, 2025 08:30
@aduh95 aduh95 marked this pull request as ready for review December 9, 2025 08:59
@aduh95 aduh95 marked this pull request as draft December 9, 2025 14:56
@aduh95 aduh95 force-pushed the fix-nosqlite-tests branch from fb7c4e1 to 672f50e Compare December 10, 2025 21:41
@aduh95 aduh95 marked this pull request as ready for review December 10, 2025 21:41
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 requested a review from cjihrig December 11, 2025 13:52
@aduh95 aduh95 merged commit 14f02fc into nodejs:main Dec 11, 2025
77 of 82 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Dec 11, 2025

Landed in 14f02fc

@aduh95 aduh95 deleted the fix-nosqlite-tests branch December 11, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants