Skip to content

Conversation

@wcr-karan
Copy link

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Nov 30, 2025
@aduh95
Copy link
Contributor

aduh95 commented Nov 30, 2025

You need to include a test that fails on main and passes with your changes

@wcr-karan
Copy link
Author

This PR fixes issue #60837.

Problem:
replServer.setupHistory() was swallowing errors thrown inside the callback starting from Node v24.2.0.

Fix:
Propagate errors thrown in the setupHistory callback and ensure they are correctly handled.

Added a test in:
test/parallel/test-repl-setup-history-error.js
to ensure the error is not swallowed.

@aduh95

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (6274eb7) to head (7e89f03).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/repl/history.js 62.50% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60903      +/-   ##
==========================================
- Coverage   88.55%   88.53%   -0.02%     
==========================================
  Files         703      703              
  Lines      208291   208292       +1     
  Branches    40170    40174       +4     
==========================================
- Hits       184443   184415      -28     
- Misses      15874    15884      +10     
- Partials     7974     7993      +19     
Files with missing lines Coverage Δ
lib/internal/repl/history.js 89.15% <62.50%> (-3.29%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants