tools: enforce trailing commas in test/sequential
#60892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60892 +/- ##
==========================================
- Coverage 88.56% 88.56% -0.01%
==========================================
Files 703 703
Lines 208291 208291
Branches 40169 40165 -4
==========================================
- Hits 184472 184470 -2
- Misses 15831 15833 +2
Partials 7988 7988 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Nov 29, 2025
aduh95
added
author ready
jakecastelli
approved these changes
Dec 1, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/60892 ✔ Done loading data for nodejs/node/pull/60892 ----------------------------------- PR info ------------------------------------ Title tools: enforce trailing commas in `test/sequential` (#60892) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:comma-dangle-sequential -> nodejs:main Labels test, author ready Commits 1 - tools: enforce trailing commas in `test/sequential` Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60892 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60892 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 29 Nov 2025 14:17:28 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60892#pullrequestreview-3520764438 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/60892#pullrequestreview-3525543837 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/19894795972 |
Contributor
Author
|
Landed in 441027a |
targos
pushed a commit
that referenced
this pull request
Dec 5, 2025
PR-URL: #60892 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only a handful missing, seems like a good time to enable it.