http,https: fix double ERR_PROXY_TUNNEL emission

[islandryu]

Fixes: #60697

Like the issue reporter, I think proxy-related errors should be handled only by the proxy logic.
Otherwise, the same root cause can lead to duplicate errors.

However, there may be cases where an error should also be emitted from within onSocket that I might be overlooking.

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (04a086a) to head (a2467bd).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60699      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         703      703              
  Lines      208220   208220              
  Branches    40137    40145       +8     
==========================================
- Hits       184374   184360      -14     
+ Misses      15861    15850      -11     
- Partials     7985     8010      +25     

Files with missing lines	Coverage Δ
lib/_http_agent.js	97.32% <100.00%> (-0.01%)	⬇️
lib/_http_client.js	97.36% <100.00%> (+<0.01%)	⬆️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70157/

[nodejs-github-bot]

Landed in 2e944d7

[jonathanperret]

Thank you for the quick fix @islandryu !
I’m not familiar with the backport policy, is there a chance this gets backported to 24.x? Trying to decide whether to deploy a workaround or wait for the next 24.x release.

[islandryu]

I think it should land in 24.12!

[rdubigny]

Hi @islandryu,

It looks like this PR didn’t make it into the 24.12 release.

Do you know if there are plans to backport it anytime soon?

[islandryu]

Sorry for the confusion.
I misunderstood the timing for backporting to earlier major versions.

According to the backporting guidelines, this non-breaking change first lands in the latest major (v25.x), and is then gradually backported to earlier release lines after it has been in the current major for at least two weeks.
https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#criteria-for-backporting