Skip to content

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Nov 5, 2025

Address performance regression in WriteUtf8V2

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7124103

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 5, 2025
@anonrig
Copy link
Member

anonrig commented Nov 5, 2025

If I remember correctly you need to update patch count by 1.

@richardlau
Copy link
Member

If I remember correctly you need to update patch count by 1.

FWIW if this has been merged upstreamin V8 @node-core/utils can handle the backport to Node.js, including incrementing the patch number and consistently formatting the commit message: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md#backporting-with-git-node-recommended

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not match the code in https://chromium-review.googlesource.com/c/v8/v8/+/7124103 or v8/v8@64b36b4 – can you align it with the actual V8 commit, or otherwise mention the reason for the divergences in the commit message?

@jasnell
Copy link
Member Author

jasnell commented Nov 5, 2025

Ah, I had mistakenly checked in the older version of the patch. Either way, I'll close this in favor of the official method @richardlau mentioned

@jasnell jasnell closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants