lib: refactor JWK import PQC support check #60586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60586 +/- ##
=======================================
Coverage 88.53% 88.54%
=======================================
Files 704 704
Lines 208072 208074 +2
Branches 40079 40080 +1
=======================================
+ Hits 184225 184230 +5
+ Misses 15875 15870 -5
- Partials 7972 7974 +2
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Nov 5, 2025
panva
added
the
author ready
Collaborator
mertcanaltin
approved these changes
Nov 5, 2025
addaleax
approved these changes
Nov 13, 2025
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
This is fine, although I think this would be quite a bit clearer if we just exposed the value of OPENSSL_WITH_PQC directly from the binding and then used that
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 537df2e |
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
PR-URL: #60586 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the check for whether AKP (PQC Algorithm Key Pair JWK types) JWK import is supported to depend on the handle's prototype method presence rather than the EVP_PKEY_* IDs.