Skip to content

Conversation

@pmarchini
Copy link
Member

This is only a draft and needs a significant amount of refactoring before it can be considered "ready for review".
I'm opening it to gather some feedback!

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 11, 2025
@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch 3 times, most recently from 5a83586 to bf4b443 Compare June 28, 2025 11:42
@pmarchini pmarchini marked this pull request as ready for review June 29, 2025 19:32
@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

❌ Patch coverage is 27.41935% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.49%. Comparing base (4ea921b) to head (6833ccc).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 24.00% 38 Missing ⚠️
lib/internal/options.js 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58680      +/-   ##
==========================================
- Coverage   88.52%   88.49%   -0.03%     
==========================================
  Files         703      703              
  Lines      208396   208430      +34     
  Branches    40185    40192       +7     
==========================================
- Hits       184483   184453      -30     
- Misses      15918    15977      +59     
- Partials     7995     8000       +5     
Files with missing lines Coverage Δ
src/node_config_file.cc 81.95% <100.00%> (ø)
src/node_config_file.h 100.00% <ø> (ø)
src/node_options.h 97.89% <ø> (ø)
lib/internal/options.js 46.82% <22.22%> (-1.42%) ⬇️
src/node_options.cc 76.23% <24.00%> (-1.53%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from bf4b443 to eab8c05 Compare July 2, 2025 09:52
@pmarchini pmarchini requested a review from marco-ippolito July 2, 2025 09:55
@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch 2 times, most recently from 2515e7f to eab8c05 Compare July 2, 2025 14:37
@pmarchini pmarchini requested review from anonrig and jasnell July 6, 2025 13:18
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from 278089f to e2bda01 Compare August 17, 2025 10:36
@nodejs-github-bot
Copy link
Collaborator

@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from e2bda01 to 01764ec Compare August 24, 2025 10:49
@nodejs-github-bot
Copy link
Collaborator

Copy link

@amilshahsahab amilshahsahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/node-config-schema.json

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito marco-ippolito added the config Issues or PRs related to the config subsystem label Oct 6, 2025
@pmarchini pmarchini force-pushed the feat/expose-option_help_text_into_config_json_schema branch from 01764ec to 6833ccc Compare December 2, 2025 20:19
@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants