-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
doc: fix return types for sync methods #58575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9ea6082 to
66d7893
Compare
|
There is also the |
|
It is a doc only change. We don't need to run CI. Can you please replace the subsystem in commit title to doc:? |
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix PR title / commit subsystem from child_process to doc
66d7893 to
9079219
Compare
|
@lpinca @Ethan-Arrowood Thanks for the review, I've updated both the PR title and commit title subsystem to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58575 +/- ##
==========================================
- Coverage 90.21% 90.13% -0.08%
==========================================
Files 635 637 +2
Lines 187494 188122 +628
Branches 36838 36893 +55
==========================================
+ Hits 169144 169572 +428
- Misses 11145 11308 +163
- Partials 7205 7242 +37
🚀 New features to boost your workflow:
|
For the sync methods spawnSync(), execSync() and execFileSync(), when the stdio option is set to anything other than 'pipe', the stdout and stderr returned from the C++ code will be null, and not a string or Buffer as currently documented.
9079219 to
d7f4826
Compare
|
I've rebased this branch, in case we need to run CI and in case this was blocked due to the previous CI run having a failing result. |
For the sync methods spawnSync(), execSync() and execFileSync(), when the stdio option is set to anything other than 'pipe', the stdout and stderr returned from the C++ code will be null, and not a string or Buffer as currently documented.
The null originates from the C++ code where:
'pipe'stdiooptions'pipe'stdiocases, it will be a null, and not a string or BufferWe can confirm the current behavior with:
The output with a build of current
mainat 641653b is: