fs: add signal option to fs.stat() by mertcanaltin · Pull Request #57775 · nodejs/node

mertcanaltin · 2025-04-06T19:15:01Z

add signal option to fs.stat() for #57751

codecov · 2025-04-06T20:04:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (d89657c) to head (7c66528).
⚠️ Report is 2109 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57775      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.02%     
==========================================
  Files         635      635              
  Lines      187588   187596       +8     
  Branches    36860    36858       -2     
==========================================
- Hits       169292   169266      -26     
- Misses      11060    11111      +51     
+ Partials     7236     7219      -17

Files with missing lines	Coverage Δ
lib/fs.js	`98.27% <100.00%> (+<0.01%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LiviaMedeiros

The commit message after subsystem should start with imperative verb and probably be more specific, maybe something like fs: add signal option to fs.stat()?

mertcanaltin · 2025-04-06T21:03:58Z

The commit message after subsystem should start with imperative verb and probably be more specific, maybe something like fs: add signal option to fs.stat()?

thank you very much, I will be more careful with this, sometimes I make the wrong sentence 🙏

nodejs-github-bot · 2025-04-11T13:36:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66196/

LiviaMedeiros

Doesn't necessarily have to be in scope of this PR, but i think we'll also need signal option for Sync and Promises API of this function, and also for the lstat version; ideally within same semver-minor release so there's no discrepancy between these functions.

targos

Test is writing a temporary file in the cwd. It should use common API instead

jasnell · 2025-04-13T16:08:37Z

@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?

mertcanaltin · 2025-04-13T17:06:25Z

@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up?

thank you I used rebase

mertcanaltin · 2025-06-01T22:22:30Z

hello I tried to fix the complex structure

nodejs-github-bot · 2026-02-27T18:38:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71486/

nodejs-github-bot · 2026-04-09T04:24:43Z

Landed in 7b6a072

Renegade334 · 2026-05-04T13:25:44Z

Does this work as intended? AFAICT, this will only abort if the signal is already aborted before the stat call. Once the actual job is created, it can't be stopped by an AbortSignal as it stands, n'est-ce pas?

PR-URL: #57775 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: buffer: * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390 crypto: * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) #62527 * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) #62553 debugger: * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713 fs: * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) #57775 * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277 http: * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) #63082 * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) #62541 lib,src,test,doc: * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) #62072 process: * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) #62878 src: * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610 stream: * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) #61098 test_runner: * (SEMVER-MINOR) align mock timeout api (sangwook) #62820 * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) #60751 * (SEMVER-MINOR) support test order randomization (Pietro Marchini) #61747 util: * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) #61556 PR-URL: #63137

mertcanaltin · 2026-05-06T05:18:38Z

@Renegade334 Thanks for ping. opened #63142 with the actual listener wiring, and #63143 for lstat/fstat/promises parity.

Notable changes: buffer: * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390 crypto: * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) #62527 * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) #62553 debugger: * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713 fs: * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) #57775 * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277 http: * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) #63082 * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) #62541 lib,src,test,doc: * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) #62072 process: * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) #62878 src: * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610 stream: * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) #61098 test_runner: * (SEMVER-MINOR) align mock timeout api (sangwook) #62820 * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) #60751 * (SEMVER-MINOR) support test order randomization (Pietro Marchini) #61747 util: * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) #61556 PR-URL: #63137

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Apr 6, 2025

jasnell reviewed Apr 6, 2025

View reviewed changes

Comment thread lib/fs.js Outdated

jasnell reviewed Apr 6, 2025

View reviewed changes

Comment thread test/parallel/test-fs-stat-abort-test.js Outdated

jasnell reviewed Apr 6, 2025

View reviewed changes

Comment thread test/parallel/test-fs-stat-abort-test.js Outdated

LiviaMedeiros reviewed Apr 6, 2025

View reviewed changes

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js Outdated

mertcanaltin force-pushed the mert/feat/fs-abort-signal branch from 291c8a6 to 911f8da Compare April 6, 2025 21:02

mertcanaltin changed the title ~~fs: added AbortSignal support~~ fs: add signal option to fs.stat() Apr 6, 2025

LiviaMedeiros added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 6, 2025

jazelly reviewed Apr 7, 2025

View reviewed changes

Comment thread lib/fs.js Outdated

jazelly reviewed Apr 7, 2025

View reviewed changes

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js Outdated

mertcanaltin force-pushed the mert/feat/fs-abort-signal branch from f9b0d0d to 9fcffb4 Compare April 8, 2025 08:03

jasnell approved these changes Apr 10, 2025

View reviewed changes

jazelly approved these changes Apr 11, 2025

View reviewed changes

Comment thread lib/fs.js Outdated

jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025

LiviaMedeiros reviewed Apr 11, 2025

View reviewed changes

Comment thread lib/fs.js Outdated

targos reviewed Apr 11, 2025

View reviewed changes

Comment thread test/parallel/test-fs-stat-abort-test.js Outdated

targos previously requested changes Apr 11, 2025

View reviewed changes

jasnell requested a review from targos April 12, 2025 17:44

jasnell reviewed Apr 12, 2025

View reviewed changes

Comment thread test/parallel/test-fs-stat-abort-test.js

jasnell approved these changes Apr 13, 2025

View reviewed changes

mertcanaltin force-pushed the mert/feat/fs-abort-signal branch from 171a72d to 99ec837 Compare April 13, 2025 17:01

This comment was marked as outdated.

Sign in to view

jazelly approved these changes Apr 13, 2025

View reviewed changes

mertcanaltin changed the title ~~fs: add signal option to fs.stat()~~ [WIP] fs: add signal option to fs.stat() Jun 1, 2025

fs: add signal option to fs.stat()

7c66528

mertcanaltin force-pushed the mert/feat/fs-abort-signal branch from ceab296 to 7c66528 Compare June 1, 2025 22:20

mertcanaltin changed the title ~~[WIP] fs: add signal option to fs.stat()~~ fs: add signal option to fs.stat() Jun 1, 2025

mertcanaltin requested review from BridgeAR, LiviaMedeiros, geeksilva97, gurgunday, jasnell and jazelly June 1, 2025 22:21

avivkeller approved these changes Dec 23, 2025

View reviewed changes

anonrig approved these changes Feb 27, 2026

View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 27, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2026

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2026

nodejs-github-bot merged commit 7b6a072 into nodejs:main Apr 9, 2026
65 checks passed

aduh95 mentioned this pull request May 5, 2026

2026-05-07, Version 26.1.0 #63137

Open

This was referenced May 6, 2026

fs: abort in-flight stat operations #63142

Open

fs: extend signal option to lstat, fstat and promises API #63143

Open

Uh oh!

Conversation

mertcanaltin commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiviaMedeiros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mertcanaltin commented Apr 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 11, 2025

Uh oh!

LiviaMedeiros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jasnell commented Apr 13, 2025

Uh oh!

mertcanaltin commented Apr 13, 2025

Uh oh!

This comment was marked as outdated.

mertcanaltin commented Jun 1, 2025

Uh oh!

nodejs-github-bot commented Feb 27, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 9, 2026

Uh oh!

Renegade334 commented May 4, 2026

Uh oh!

mertcanaltin commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

mertcanaltin commented Apr 6, 2025 •

edited

Loading

codecov Bot commented Apr 6, 2025 •

edited

Loading

mertcanaltin commented May 6, 2026 •

edited

Loading