Copying node.lib timestamp to prevent redundant link with msbuild#951
Closed
idobh2 wants to merge 1 commit intonodejs:masterfrom
Closed
Copying node.lib timestamp to prevent redundant link with msbuild#951idobh2 wants to merge 1 commit intonodejs:masterfrom
idobh2 wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
It seems there is no need to copy I have a PR for that: #964 |
Closed
Member
|
#964 landed addressing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed node-gyp build always creates a new .node binary even when no code/lib were changed.
Turns out that the fact that node.lib copy is created by writing the file each time, which changes its timestamp, is causing msbuild.exe to trigger a link operation.
writing the file, and copying the timestamp resolves this issue.