Skip to content

feat: Support for Visual Studio 2026 (18.x) to enable node-gyp to work with the latest Visual Studio preview and release versions. #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukekarrys merged 1 commit into from
Nov 12, 2025
+1,243 −13
Merged

feat: Support for Visual Studio 2026 (18.x) to enable node-gyp to work with the latest Visual Studio preview and release versions. #3240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/find-visualstudio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class VisualStudioFinder {
}

async findVisualStudio2019OrNewerFromSpecifiedLocation () {
return this.findVSFromSpecifiedLocation([2019, 2022])
return this.findVSFromSpecifiedLocation([2019, 2022, 2026])
}

async findVisualStudio2017FromSpecifiedLocation () {
Expand Down Expand Up @@ -162,7 +162,7 @@ class VisualStudioFinder {
}

async findVisualStudio2019OrNewerUsingSetupModule () {
return this.findNewVSUsingSetupModule([2019, 2022])
return this.findNewVSUsingSetupModule([2019, 2022, 2026])
}

async findVisualStudio2017UsingSetupModule () {
Expand Down Expand Up @@ -223,7 +223,7 @@ class VisualStudioFinder {
// Invoke the PowerShell script to get information about Visual Studio 2019
// or newer installations
async findVisualStudio2019OrNewer () {
return this.findNewVS([2019, 2022])
return this.findNewVS([2019, 2022, 2026])
}

// Invoke the PowerShell script to get information about Visual Studio 2017
Expand Down Expand Up @@ -389,6 +389,10 @@ class VisualStudioFinder {
ret.versionYear = 2022
return ret
}
if (ret.versionMajor === 18) {
ret.versionYear = 2026
return ret
}
this.log.silly('- unsupported version:', ret.versionMajor)
return {}
}
Expand Down Expand Up @@ -456,6 +460,8 @@ class VisualStudioFinder {
return 'v142'
} else if (versionYear === 2022) {
return 'v143'
} else if (versionYear === 2026) {
return 'v145'
Copy link
Member

@legendecas legendecas Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this version has not been updated in the doc yet: https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros

Copy link
Contributor Author

@xxairsky xxairsky Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this version has not been updated in the doc yet: https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros

Clearly, Microsoft's development team is far behind in terms of documentation update speed.

However, I can assure you that VS2026 uses version 145 and has passed rigorous unit and compilation tests.

My personal product has been successfully compiled and released using this PR. ;)

}
this.log.silly('- invalid versionYear:', versionYear)
return null
Expand Down
Loading