fix: replace weak hash functions with SHA-256#3168
Closed
guan404ming wants to merge 1 commit intonodejs:mainfrom
Closed
fix: replace weak hash functions with SHA-256#3168guan404ming wants to merge 1 commit intonodejs:mainfrom
guan404ming wants to merge 1 commit intonodejs:mainfrom
Conversation
legendecas
reviewed
Jun 20, 2025
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
Would you mind submitting changes in gyp/ to https://github.com/nodejs/gyp-next first? Thank you!
Author
|
Here is the pr nodejs/gyp-next#329! |
Author
|
I've resolved the pr conflict, thanks! |
Contributor
|
I believe this can be closed because it will come into this codebase on the next sync with |
Member
|
Synchronization done in #3273. Thank you for your work on this! |
Author
|
Thanks for the review and help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
This PR replaces weak cryptographic hash functions (MD5 and SHA1) with SHA-256 across the
node-gypcodebase to improve security. The changes affect hash generation for:Security Impact: Addresses potential security vulnerabilities by replacing deprecated hash functions that are susceptible to collision attacks.
Performance & Functionality: No impact on build speed or functionality. All existing features work exactly the same with stronger security guarantees.
Compatibility: Maintains full backward compatibility while using modern cryptographic standards.