Support embed url card #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
force-pushed
the
embed-card
branch
from
4b0c899 to
944754d
Compare
github-actions
bot
added
documentation
Member
Author
|
Need some reviews @nodejs/bluesky @nodejs/tsc |
jasnell
approved these changes
Jan 6, 2025
Member
Author
|
Tested again locally, noticed that there is a minor fix needed to the integration test scripts after #46 (result is now an array). Applied the fix. Probably does not need a re-review from anyone. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bsky.app/profile/pixel-voyager.bsky.social/post/3ldu5awduic25 for a preview.
Drive-by: rename PIXEL to PRIMARY, so later we can rename the secrets here as PRIMARY too, which makes testing easier.
Fixes: #20