Skip to content

Conversation

@joyeecheung
Copy link
Member

Reopened from #17 because I discovered that we need to disable https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches to stop GitHub from automatic deletion of the PR branch.

aduh95 and others added 2 commits December 10, 2024 19:29
* post: v23.4.0 announcement

* Update records/new/v23.4.0-announcement.json

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

* Update records/new/v23.4.0-announcement.json

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

---------

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung
Copy link
Member Author

Adding an edit to remove the redundant \n at the end. Let's see if squashing and merging this time is okay.

@joyeecheung joyeecheung merged commit 3d871f9 into main Dec 10, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Dec 10, 2024
@richardlau richardlau deleted the 23-4-0 branch December 10, 2024 19:00
@AugustinMauroy
Copy link
Member

AugustinMauroy commented Dec 10, 2024

Capture d’écran 2024-12-10 à 21 52 22

BTW, we should explicitly write with version of node is impacted because BSK trunk the link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants