Skip to content

Conversation

@github-actions
Copy link
Contributor

No description provided.

@joyeecheung joyeecheung marked this pull request as ready for review June 22, 2025 14:58
@joyeecheung joyeecheung requested a review from a team as a code owner June 22, 2025 14:58

https://github.com/nodejs/bluesky/discussions/140

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hoping #129 has fixed it enough to handle a relatively long thread like this.. if you want to push the merge button, please watch it out and check the thread is posted correctly after the workflow finishes.

@joyeecheung
Copy link
Member

cc @nodejs/tsc @nodejs/marketing @nodejs/bluesky

Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
@joyeecheung joyeecheung merged commit 4183196 into main Jun 23, 2025
1 check passed
@joyeecheung joyeecheung deleted the action/aac1c1b7-cbed-4b62-a090-d0abfb1b54d5 branch June 23, 2025 13:42
@joyeecheung
Copy link
Member

Fetching image https://opengraph.githubassets.com/1e95d693253979d0e6ea6dece6fc233a64609a4f20450d25afc2ea474bf2e7a1/nodejs/bluesky/discussions/133
Failed to fetch or upload image https://opengraph.githubassets.com/1e95d693253979d0e6ea6dece6fc233a64609a4f20450d25afc2ea474bf2e7a1/nodejs/bluesky/discussions/133 Error: Failed to fetch image https://opengraph.githubassets.com/1e95d693253979d0e6ea6dece6fc233a64609a4f20450d25afc2ea474bf2e7a1/nodejs/bluesky/discussions/133: 502 Bad Gateway
    at populateRecord (file:///home/runner/work/bluesky/bluesky/actions/lib/posts.js:219:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async post (file:///home/runner/work/bluesky/bluesky/actions/lib/posts.js:288:22)
    at async file:///home/runner/work/bluesky/bluesky/actions/process.js:43:16

The reply failed when trying to fetch the embed card image from GitHub. I will post the replies manually.

(Probably need to implement some retry logic for the image fetching..)

@joyeecheung
Copy link
Member

joyeecheung commented Jun 23, 2025

Actually when posting manually I noticed that Bluesky's web UI handled the failures by just ignoring them and create an embed without the card image (like this https://bsky.app/profile/nodejs.org/post/3lsbprjmc6c25). Which I think is a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants