Add .gitignore entries for sensitive files#193
Add .gitignore entries for sensitive files#193pete-builds wants to merge 3 commits intonode-strava:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.gitignore (1)
40-42: Consider un-ignoring.env.exampleto preserve tracked templates.Line 41 (
.env.*) will also ignore.env.example. If this repo uses an example env template for onboarding, add an explicit negation rule.Suggested tweak
.env .env.* +!.env.example *.pem *.key🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore around lines 40 - 42, The current ignore pattern ".env.*" will also exclude the tracked template ".env.example"; update the .gitignore by adding an explicit negation for the example file (e.g., add a pattern to un-ignore ".env.example") placed after the ".env.*" entry so the template remains tracked and other env variants stay ignored.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Around line 40-42: The current ignore pattern ".env.*" will also exclude the
tracked template ".env.example"; update the .gitignore by adding an explicit
negation for the example file (e.g., add a pattern to un-ignore ".env.example")
placed after the ".env.*" entry so the template remains tracked and other env
variants stay ignored.
|
Revised — removed the credential and certificate entries that aren't relevant to this project. |
The .gitignore is missing entries for
.envfiles and private keys (*.pem,*.key). Added those to help prevent accidental commits of credentials.Summary by CodeRabbit