Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@
"tshy": "^3.3.2",
"tshy-after": "^1.4.1",
"typescript": "^5.9.3",
"vite-plus": "^0.1.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.4"
"vite-plus": "^0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.6"
},
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.4"
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.6"
Comment on lines +105 to +110

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For dependencies with a major version of 0 (e.g., 0.x.y), it's a good practice to pin the version instead of using a caret (^). According to semantic versioning, versions below 1.0.0 can introduce breaking changes even in minor or patch releases. Pinning the versions (e.g., using "0.1.6" instead of "^0.1.6") will prevent unexpected breaking changes from being pulled in on subsequent installs, improving the stability and predictability of the build. This applies to both devDependencies and overrides.

Suggested change
"vite-plus": "^0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.6"
},
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.4"
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.6"
"vite-plus": "0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.6"
},
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.6"

},
"tshy": {
"exports": {
Expand All @@ -121,8 +121,8 @@
"packageManager": "pnpm@10.32.0",
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.4"
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.6"
Comment on lines +124 to +125

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and to prevent potential breaking changes, it's best to pin the versions in pnpm.overrides as well for these pre-1.0.0 packages.

Suggested change
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.6"
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.6"

},
"peerDependencyRules": {
"allowAny": [
Expand Down
Loading
Loading