Refactor screen recorder to single-process architecture, add a control panel and new settings#867
Open
fliplus wants to merge 3 commits into
Open
Conversation
…ral refactoring, add control panel and new settings
Contributor
|
@Ly-sec - this PR modifies your plugin. Please review when you have a chance. |
Contributor
Automatic Code Quality ReviewFile: screen-recorder/BarWidget.qml
property string widgetId: ""
property string section: ""
property int sectionWidgetIndex: -1
property int sectionWidgetsCount: 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recording and replay buffer now share a single process instead of two separate process trees. State is driven by actual process events rather than timers. A new panel and several settings were added.
New Features
Changes
recorderProcessshared by both modes (recording and replaying); all replay-specific processes were removedisPending,isReplayPending,hasActiveRecordingand all associated timers; state is now two booleans (isRecording,isReplaying) driven directly by process eventsbackendCheckProcess; the startupcheckerprocess andisAvailablestate removedSIGRTMIN) instead of launching a new processVideo_yyyy-MM-dd_HH-mm-ss.mp4; the user-configurablefilenamePatternsetting was removed. This was done for consistency with replay mode, which does not support custom file namestoggle->toggleRecording,start->startRecording,stop->stopRecordingreplayEnabledsetting, replay is always available1.3.7->1.4.0Notes: I have only tested this on NixOS with Niri and the native
gpu-screen-recorderpackage. Flatpak and Hyprland have not been tested. Non-English translations were generated with AI, I cannot guarantee they are accurate.