Skip to content

RSS-FEED: Add option to show only when unread#798

Open
NullSeile wants to merge 3 commits into
noctalia-dev:mainfrom
NullSeile:feat/show-only-when-unread
Open

RSS-FEED: Add option to show only when unread#798
NullSeile wants to merge 3 commits into
noctalia-dev:mainfrom
NullSeile:feat/show-only-when-unread

Conversation

@NullSeile
Copy link
Copy Markdown

Adds the option to hide the bar widget when there are no unread posts.

@github-actions
Copy link
Copy Markdown
Contributor

@lokize - this PR modifies your plugin. Please review when you have a chance.

@github-actions
Copy link
Copy Markdown
Contributor

Automatic Code Quality Review


File: rss-feed/Settings.qml

  • (L) Line 159: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")
+            label: pluginApi?.tr("settings.showOnlyWhenUnread", "Show Only When Unread") || "Show Only When Unread"
  • (L) Line 160: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")
+            description: pluginApi?.tr("settings.showOnlyWhenUnreadDesc", "Only show the widget when there are unread articles") || "Only show the widget when there are unread articles"

@NullSeile
Copy link
Copy Markdown
Author

I was wondering if i should fix these problems, as they are from previous commits.

If you want me to, i can very much do so.

@spiros132
Copy link
Copy Markdown
Collaborator

Please do fix the problems if you can :)

@NullSeile
Copy link
Copy Markdown
Author

I've fixed the translations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants