feat(netbird): Add custom terminal command support for SSH and Ping actions#530
Merged
ItsLemmy merged 3 commits intonoctalia-dev:mainfrom Apr 7, 2026
Merged
feat(netbird): Add custom terminal command support for SSH and Ping actions#530ItsLemmy merged 3 commits intonoctalia-dev:mainfrom
ItsLemmy merged 3 commits intonoctalia-dev:mainfrom
Conversation
Contributor
Automatic Code Quality ReviewFile: netbird/Main.qml
property var pluginApi: nullFile: netbird/Panel.qml
property var pluginApi: null
readonly property var geometryPlaceholder: panelContainer
readonly property bool allowAttach: trueFile: netbird/Settings.qml
+ label: pluginApi?.tr("settings.terminal") || "Terminal Configuration"
+ description: pluginApi?.tr("settings.terminal-desc") || "Set a custom terminal command or leave blank for auto-detection"
+ return (pluginApi?.tr("settings.terminal-detected") || "Auto-detected") + ": " + detected;
return pluginApi?.tr("settings.terminal-none") || "No terminal emulator detected";
property var pluginApi: null |
Contributor
|
@Cleboost - this PR modifies your plugin. Please review when you have a chance. |
Contributor
|
@spiros132 can you take a look? |
spiros132
reviewed
Apr 2, 2026
| } | ||
| "id": "netbird", | ||
| "name": "NetBird", | ||
| "version": "1.0.1", |
Collaborator
There was a problem hiding this comment.
Looks good, just don't forget to bump the version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configuring a custom terminal command in the NetBird plugin settings, to be used when launching SSH or Ping actions.
Also handles passing arguments correctly by using
--for terminals that require it (like ptyxis, gnome-terminal, wezterm), while falling back to-efor others.Changes:
terminalCommandtomanifest.jsondefaults.NTextInputinSettings.qmlto allow users to specify a custom terminal command.detectTerminalinMain.qmlto respect the user's custom terminal command if provided, bypassing auto-detection.Panel.qmlto read the configured terminal command and construct the execute command appropriately usingbuildTerminalCmdto account for different execution flags (-evs--).