Add add_analyzer functionality#3
Conversation
|
|
||
| private: | ||
| rclcpp::Client<rcl_interfaces::srv::SetParametersAtomically>::SharedPtr client_; | ||
| std::string prefix_ = "analyzers."; |
There was a problem hiding this comment.
perhaps a little more clarity could help with the name. Something like a node_param_ns_,?
|
Great, please fix the linting (See CI) and rebase of the |
7ca53cd to
8c85be7
Compare
8c85be7 to
863d110
Compare
817e6f6 to
f3b4b35
Compare
f3b4b35 to
d8c28eb
Compare
…:nobleo/diagnostics into feature/add-analyzers-through-parameters
… service namespace from diagnostics_agg to analyzers
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2009, Willow Garage, Inc. |
There was a problem hiding this comment.
Did you write this code or adapted this from somewhere? If you wrote it yourself, this should be the BV where you work for, so Copyright 2024 Nobleo Autonomous Solutions B.V.
There was a problem hiding this comment.
Wrote it myself but just copied the pasta for the notice and forgot to make it Nobleo Technology or whatever it should be, will update.
| * copyright notice, this list of conditions and the following | ||
| * disclaimer in the documentation and/or other materials provided | ||
| * with the distribution. | ||
| * * Neither the name of the Willow Garage nor the names of its |
There was a problem hiding this comment.
Just use the standard BSD sentences:
3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
There was a problem hiding this comment.
Should I change it? Now the license matches all the other files in the repo.
There was a problem hiding this comment.
Oh, yeh I see what you mean now it can't stay willow garage :P
…ger, remove unnecessary hardcoded namespace from yaml files
…fter copying the notice
Applied the following changes:
Move the creation of
analyzer_group_andother_analyzer_from the constructor to a new functioninitAnalyzers().Added a subscriber to parameter events
param_sub_that triggers a callbackparameterCallback.Check in the callback if
thisnode got any new paramters -> if true, lock the mutex and callinitAnalyzers()again.Created an
add_analyzernode that forwards its own parameters to thediagnostic_aggregatorby sending a request to/diagnostics_agg/set_parameters_atomicallyserviceThe
add_analyzerlooks for all parameters starting with the prefixanalyzers., converts them to a parameter_msg and sends them together as oneSetParametersAtomically::RequestExample usage: