[Fix] process dat issue with facetting#251
Open
Schiano-NOAA wants to merge 28 commits intomainfrom
Open
Conversation
… than if else nested
… needed in if statemnet
… csv more efficient; remove mod-name2 and keep as just module name
… Originally found when using plot_indices
Contributor
New version checklist
|
Contributor
Code Metrics Report
Code coverage of files in pull request scope (52.5%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue I identified when facetting is explicit in the plot_indices function.
I made adjustments to automatic detection and assignment of facet in the process_data function specifically so it does not overwrite facet or include the facet as group when it's the first indexing found in the index_variable object
plan release for v0.11.1