[Hotfix] change the default era to NULL in multiple functions#236
Open
Schiano-NOAA wants to merge 8 commits intomainfrom
Open
[Hotfix] change the default era to NULL in multiple functions#236Schiano-NOAA wants to merge 8 commits intomainfrom
Schiano-NOAA wants to merge 8 commits intomainfrom
Conversation
Contributor
New version checklist
|
Schiano-NOAA
force-pushed
the
hotfix-default-era
branch
from
5c6be3e to
69cd8df
Compare
* [Fix] plot_indices (#221) * initial commit of new obs v pred plot * adjust process data so it converts all indexed data to character to function even when input values are numeric per #212 * update plot indices to use new plot_obsvpred function and adjust based on needs * update documentation for package * adjust plot_indices where nfleet = 1 and update test to remove new file produced * add missing dependency * Address #218 by scaling uncertainty intervals if relative = TRUE for B and SB plots * remove previous calcs of relative and add if statement instead * adjust relative=TRUE cases to extract proportion from model rather than calc in fxn * add era into arg for plot_biomass * reflect changes for plotting relative values from the model for spawning_biomass * add other option to find biomass when relative * remove relative option from reference_line * adjust ref line when ref is unfished becomes point * remove option to be relative in F plot * remove commented out code * move placement of unfished reference point in if statement * update documentation * remove outdated tests for sb plot * remove extra test and fix relative testing * remove relative example from sb plt since it doesnt exist in the example data * update documentation * remove rel F quantities --------- Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com>
Schiano-NOAA
force-pushed
the
hotfix-default-era
branch
from
69cd8df to
a977c2f
Compare
* change the default era to NULL in multiple functions * adjust sr fxn to use process data -- does not plot line currently * update sr plot to consider obs v est recuirtment and curve * update SR plot example
Schiano-NOAA
force-pushed
the
main
branch
2 times, most recently
from
b057594 to
5cabc07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting default era to NULL instead of "time" so nothing is unnecessarily filtered by default
Plan release for v0.11.1