[Feature] Add Rceattle as compatible model in convert_output(...)#209
Open
Schiano-NOAA wants to merge 27 commits into
Open
[Feature] Add Rceattle as compatible model in convert_output(...)#209Schiano-NOAA wants to merge 27 commits into
Schiano-NOAA wants to merge 27 commits into
Conversation
5 tasks
Contributor
New version checklist
|
Contributor
Code Metrics Report
Code coverage of files in pull request scope (52.8%)
Reported by octocov |
686cc93 to
ac13440
Compare
Collaborator
Author
|
Edits:
Note: I was unable to align log_index_hat with catch since they are different lengths of data, 101 and 74, respectively |
0e1e56c to
f0881ac
Compare
b057594 to
5cabc07
Compare
f0881ac to
da22202
Compare
Collaborator
Author
|
To test, run the following code then use the "x_model" environment objects as the dat argument in |
Collaborator
Author
|
@sbreitbart-NOAA I will leave it up to you if you want to test this functionality. The download process to get the example data can be long. Otherwise, feel free to review the rest of this PR. Thanks! On another thought: maybe I could add the rceattle data as another test input into {stockplotr}? |
… than if else nested
… needed in if statemnet
… csv more efficient; remove mod-name2 and keep as just module name
72b38a8 to
9d2d967
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to standardize Rceattle output and standardize naming conventions from elements in the model output object.
Plan release for v0.11.0