Skip to content

Conversation

@Schiano-NOAA
Copy link
Collaborator

@Schiano-NOAA Schiano-NOAA commented Nov 5, 2025

What is the feature?

  • Renaming module_names from SS3 and BAM in order to keep consistency between them and FIMS along with establishing consistency in output

How have you implemented the solution?

  • Added new column to naming sheets and implemented it in the code

Does the PR impact any other area of the project, maybe another repo?

  • yes, this will impact some things in stockplotr and require some testing and potentially changes to stockplotr

Do not merge or review this PR

We will need review from SS3 and BAM specialist to confirm that the module names are accurate and the ones we want to use

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Checklist

  • PR base branch is accurate
  • Is the code concise?
  • Comments are clear and useful.
  • Can you remove or combine any arguments?
  • Do argument contain defaults (if appliable)?
  • Code is documented and example provided (Roxygen).
  • Did you make a test (testthat)?
  • Was this tested under multiple scenarios?
  • Did you run devtools::check()?

@Schiano-NOAA Schiano-NOAA changed the base branch from main to dev November 5, 2025 15:20
Base automatically changed from dev to main December 16, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants