added center_scale_norm#5
Merged
Merged
Conversation
JiamingPan
reviewed
May 1, 2026
Collaborator
JiamingPan
left a comment
There was a problem hiding this comment.
Two small questions:
- The function center_scale_norm still says median/absolute deviation, but the code uses mean/max-abs. Should we update the docstring?
- center_scale_norm currently mutates x in-place with x -= avg and x /= x.abs().max(). Since load_data can use tensors backed by NumPy memmaps, should this be out-of-place, e.g.
x = x - x.mean(); x = x / x.abs().max(), to avoid the non-writable-array warning?
Owner
Author
|
great points, will fix this, thanks! |
Owner
Author
|
@JiamingPan lmk if you have any other concerns! if not I will merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
center_scale_normthat centers and then normalizes by absolute deviation. Need to keep data centered to train diffusion models with a mean-zero noise scheduler