Skip to content

Please consider the following formatting changes to #12736 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 1 commit into from
Sep 8, 2025
Merged

Please consider the following formatting changes to #12736 #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Common/TableProducer/ft0CorrectedTable.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Provide mandatory file documentation.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -8,7 +8,7 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.

Check failure on line 11 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \author is missing, incorrect or misplaced.

Check failure on line 11 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.

Check failure on line 11 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.
#include "Common/Core/CollisionTypeHelper.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/FT0Corrected.h"
Expand All @@ -34,14 +34,11 @@
#include <cstdint>
#include <string>

#include <bitset>
#include <string>

using namespace o2;
using namespace o2::framework;
using namespace o2::aod;

struct ft0CorrectedTable {

Check failure on line 41 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/struct] 

Use UpperCamelCase for names of structs.
// Configurables
Configurable<float> resoFT0A{"resoFT0A", 20.f, "FT0A resolution in ps for the MC override"};
Configurable<float> resoFT0C{"resoFT0C", 20.f, "FT0C resolution in ps for the MC override"};
Expand All @@ -56,7 +53,7 @@
Produces<o2::aod::FT0sCorrected> table;
using BCsWithMatchings = soa::Join<aod::BCs, aod::Run3MatchedToBCSparse>;
using CollisionEvSel = soa::Join<aod::Collisions, aod::EvSels>::iterator;
static constexpr float invLightSpeedCm2NS = 1.f / o2::constants::physics::LightSpeedCm2NS;

Check failure on line 56 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".

HistogramRegistry histos{"Histos", {}, OutputObjHandlingPolicy::AnalysisObject};
void init(o2::framework::InitContext&)
Expand Down Expand Up @@ -89,8 +86,8 @@
t0A = 1e10f;
t0C = 1e10f;
const float vertexPV = collision.posZ();
const float vertex_corr = vertexPV * invLightSpeedCm2NS;

Check failure on line 89 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/function-variable] 

Use lowerCamelCase for names of functions and variables.
constexpr float dummyTime = 30.; // Due to HW limitations time can be only within range (-25,25) ns, dummy time is around 32 ns

Check failure on line 90 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
if (collision.has_foundFT0()) {
const auto& ft0 = collision.foundFT0();
const std::bitset<8>& triggers = ft0.triggerMask();
Expand All @@ -109,7 +106,7 @@
if (addHistograms) {
histos.fill(HIST("t0A"), t0A);
histos.fill(HIST("t0C"), t0C);
if (t0A < 1e10f && t0C < 1e10f) {

Check failure on line 109 in Common/TableProducer/ft0CorrectedTable.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
histos.fill(HIST("t0AC"), (t0A + t0C) * 0.5f);
histos.fill(HIST("deltat0AC"), (t0A - t0C) * 0.5f);
histos.fill(HIST("deltat0ACps"), (t0A - t0C) * 500.f);
Expand Down
Loading