Skip to content

perf(rollup): skip URI-scheme ids before this.resolve()#4253

Draft
danielroe wants to merge 1 commit into
v2from
perf/fast-path-resolve
Draft

perf(rollup): skip URI-scheme ids before this.resolve()#4253
danielroe wants to merge 1 commit into
v2from
perf/fast-path-resolve

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented May 9, 2026

🔗 Linked issue

spotted this while investigating nuxt/nuxt#27106.

related: nuxt/nuxt#34753

this makes a measureable difference in terms of nuxt build performance

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this is a perf improvement porting some changes that have already been made in main branch (but which I discovered somewhat differently via nuxt/nuxt#27106):

  • fast return for node: builtins
  • fast return for data:, http(s):, virtual:, bun:, deno:, etc.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 as a code owner May 9, 2026 11:06
@vercel
Copy link
Copy Markdown

vercel Bot commented May 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nitro.build Ready Ready Preview, Comment May 9, 2026 11:07am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6a4fab0f-229a-4f42-b243-35ad54fcd437

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/fast-path-resolve

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 10, 2026

Open in StackBlitz

npm i https://pkg.pr.new/nitropack@4253

commit: fd250ae

@pi0
Copy link
Copy Markdown
Member

pi0 commented May 11, 2026

Thanks. Pending as i have to carefully review for backport.

@pi0 pi0 marked this pull request as draft May 11, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants