fix(aws-lambda): add preview command#4052
Conversation
Export fetch from aws-lambda, aws-lambda-streaming presets Add streaming preview shim
|
@taylorfsteele is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds AWS Lambda preset preview command support with streaming capabilities. Introduces default exports for fetch functionality in runtime presets and creates a preview shim utility for streaming mode compatibility. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
#4051
❓ Type of change
📚 Description
Closes #4051
This PR adds a preview command for the
aws-lambdapreset.In order to get the preview command working correctly, two additional changes were added:
nitroApp.fetch.presets/standard/runtime/server.tsafter running into issues where the preview command was unable to load correctly. I'm very open to excluding this from the PR and moving this to a more Vite or App level concern, as I'm not entirely unsure about the ramifications of this change. I'm not exactly sure how to do that, but let me know what you think.awslambdaglobals to the preview command.📝 Checklist