-
-
Notifications
You must be signed in to change notification settings - Fork 812
feat: nitro preview
#4024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: nitro preview
#4024
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2ecfeea
feat: `nitro preview`
pi0 ff7ed43
wip
pi0 b019c80
Merge branch 'main' into feat/nitro-preview
pi0 d7311a1
Merge branch 'main' into feat/nitro-preview
pi0 92be477
load dotenv in mem
pi0 a5010c0
update vite
pi0 a8df635
websocket support
pi0 e7f3b24
Merge branch 'main' into feat/nitro-preview
pi0 fe99f05
update commands
pi0 84334bc
vite: avoid additional traps
pi0 89b1f9c
simplify preview
pi0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { defineCommand } from "citty"; | ||
| import { resolve } from "pathe"; | ||
| import { commonArgs } from "../common.ts"; | ||
| import { startPreview } from "../../preview.ts"; | ||
| import { serve } from "srvx"; | ||
| import { log } from "srvx/log"; | ||
|
|
||
| export default defineCommand({ | ||
| meta: { | ||
| name: "preview", | ||
| description: "Start a local server to preview the built server", | ||
| }, | ||
| args: { | ||
| ...commonArgs, | ||
| port: { type: "string", description: "specify port" }, | ||
| host: { type: "string", description: "specify hostname" }, | ||
| }, | ||
| async run({ args }) { | ||
| const rootDir = resolve((args.dir || args._dir || ".") as string); | ||
|
|
||
| const server = serve({ | ||
| fetch(req) { | ||
| return preview.fetch(req); | ||
| }, | ||
| middleware: [log()], | ||
| gracefulShutdown: false, | ||
| port: args.port, | ||
| hostname: args.host, | ||
| }); | ||
|
|
||
| const preview = await startPreview({ | ||
| rootDir, | ||
| loader: { srvxServer: server }, | ||
| }); | ||
|
|
||
| if (preview.upgrade) { | ||
| server.node?.server?.on("upgrade", (req, socket, head) => { | ||
| preview.upgrade!(req, socket, head); | ||
| }); | ||
| } | ||
|
|
||
| process.on("SIGINT", async () => { | ||
| await server.close(); | ||
| await preview.close(); | ||
| process.exit(0); | ||
| }); | ||
| }, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TDZ race:
previewis accessed insidefetchbeforeconstdeclaration executes.previewis declared withconston line 31 but referenced in thefetchclosure on line 23. If any request arrives betweenserve()starting the listener andawait startPreview()resolving, accessingpreviewthrows aReferenceErrordue to the Temporal Dead Zone.Since
serve()needs to be created first (to passserverintostartPreviewvialoader), use aletvariable declared beforeserve():Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents