escape dollar signs along with our quotes

[pudge]

self.escape_quotes is used for putting everything in double quotes, but a $ in double quotes isn't happy, for example:

Running command: git tag -a -m "fix ${ => #{ typo" "FOO@7974" "svn/tags/FOO@7974"
sh: 1: Syntax error: Unterminated quoted string
command failed:
git tag -a -m "fix ${ => #{ typo" "FOO@7974" "svn/tags/FOO@7974"

With this patch:

Running command: git tag -a -m "fix \${ => #{ typo" "FOO@7974" "svn/tags/FOO@7974"

[pudge]

Ugh. Just found out that this breaks too:

Running command: git tag -a -m "new tag`" "FOO_16" "svn/tags/FOO_16"
sh: 1: Syntax error: EOF in backquote substitution
command failed:
git tag -a -m "new tag`" "FOO_16" "svn/tags/FOO_16"

Need to escape this, too:

git tag -a -m "new tag\`" "FOO_16" "svn/tags/FOO_16"

There's got to be a better generalized solution.

[spraints]

Would Shellwords.escape be a good fit here?

[pudge]

Possibly. I am not a ruby guy, but it looks good. However, we are not just passing this to the shell, we are passing it to the shell and putting it in double quotes. I think if we used shellwords.escape we might also want to change all the calling instances to not be wrapped in double quotes. Not sure.

[nirvdrum]

I believe we've had to remove it in the past because it's not implemented in Ruby 1.8. A large number of svn2git users don't otherwise manage Ruby installations, so they just install on whatever their system already has. We support at least the Ubuntu LTS releases (so, going back 5 years) and a couple versions of MacOS X.

I'd need to reevaluate since Ubuntu 10.04 has now fallen off the support path, but we might not be able to realistically use any 1.9+ specific methods yet.

[normanyee]

I ran into the same problem as pudge and was going to post a similar pull request until I found pudge's. Is this pull request going to be merged?