Closed
Conversation
- Split .cursor/rules/instructions.txt into 7 logical .mdc files - Created .cursor/rules/claude.md index linking to all sections - Created root-level claude.md linking to rules and index - Preserved original instructions.txt file - Added numbered sections: llm-info, corey-info, corey-behavior, nodejs-style-guide, typescript-style-guide, encore-ts-domain-knowledge, encore-cli-reference
- Add CI workflow for pull requests to main branch - Includes PostgreSQL service for database testing - Runs backend tests with Encore CLI - Runs frontend tests with Bun - Builds both backend and frontend - Uses latest Bun version and Encore CLI
…each .mdc rule file\n- Add helper script to ensure we only keep the first block\n- Run script to dedupe encore domain knowledge and CLI docs
- Update Environment() to use steering-wheel-documentation-65b2-.encr.app - Ensure generated URLs place environment name as suffix to app ID
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
nirukk52
added a commit
that referenced
this pull request
Nov 6, 2025
…g sync - Update CODE_REVIEW.md: mark magic strings and hardcoded config as fixed - Fix backend/graph/stream.ts: use RUN_ENDED_STATUSES constant (no magic strings) - Fix frontend config: extract defaults to frontend/src/lib/config.ts with env overrides - Add FR-010 feature request: centralized run defaults via Encore endpoint - Update debugging skills: add WebSocket/Docker infrastructure notes - Update handoff docs: document graph stream debugging findings Resolves CODE_REVIEW critical issues #1 and #2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the generated cloud environment URLs from the Encore client to ensure the environment name appears as a suffix rather than a prefix.
Changes
Environment(name: string)infrontend/client.tsto returnhttps://steering-wheel-documentation-65b2-${name}.encr.appTesting
Note
Fixes cloud URL construction in the TS client, adds a CI pipeline, and introduces AI rules/docs with minor doc and tooling updates.
frontend/client.tsEnvironment(name)to usehttps://steering-wheel-documentation-65b2-${name}.encr.app; adjust generated headers/labels..github/workflows/ci.ymlto set up Postgres, install Bun and Encore CLI, run backend/frontend tests, and build both apps..cursor/rules/*.mdc, indexclaude.md, andinstructions_archived.txt..cursor/rules/dedupe_rules.jsto trim duplicate XML blocks.DEVELOPMENT.mdlinks; addbackend/.gitignore; reviseseed.mdcontent/title.Written by Cursor Bugbot for commit 5ae17f7. This will update automatically on new commits. Configure here.